Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47168: List feature macros in the stable ABI manifest, improve tests #32415

Merged
merged 9 commits into from Apr 28, 2022
Merged

bpo-47168: List feature macros in the stable ABI manifest, improve tests #32415

merged 9 commits into from Apr 28, 2022

Conversation

encukou
Copy link
Member

@encukou encukou commented Apr 8, 2022 •
edited by bedevere-bot

This depends on #32414. The refactoring+tests should go in a separate commit.

I plan some more deduplication, and use the name “feature macro” rather than ifdef everywhere, after converting stable-abi.txt to TOML so it's easier to work with.

https://bugs.python.org/issue47168

@encukou encukou requested a review from as a code owner Apr 8, 2022
@encukou encukou marked this pull request as draft Apr 8, 2022
@encukou encukou marked this pull request as ready for review Apr 22, 2022
@encukou encukou added the 🔨 test-with-buildbots label Apr 22, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 22, 2022

🤖 New build scheduled with the buildbot fleet by @encukou for commit 896f4d0 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 22, 2022
@encukou encukou merged commit 6dcbc08 into python:main Apr 28, 2022
85 of 86 checks passed
@encukou encukou deleted the stable-ifdef branch Apr 29, 2022
@encukou encukou mentioned this pull request Apr 29, 2022
Closed
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue May 1, 2022
@encukou @gvanrossum
pythongh-91324: List feature macros in the stable ABI manifest, impro…
f9228cf 
…ve tests (pythonGH-32415)
gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue May 1, 2022
@encukou @gvanrossum
pythongh-91324: List feature macros in the stable ABI manifest, impro…
e12ce7d 
…ve tests (pythonGH-32415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@encukou @bedevere-bot @the-knights-who-say-ni