Replace ioutil with io and os #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
previously requested changes
Apr 25, 2022
Hi, thanks for doing the heavy lifting! The change looks good to me, but it looks like it causes a few test failures. Could you please look into those?
samcoe
approved these changes
Apr 26, 2022
This looks good to me. I rebased trunk to fix conflicts and also pushed a fix for the tests that were broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #5495
iostreamsused the variowhich is unfortunate since it collides withiofrom the standard library, so renamed it toios