Ruby: dont import the PathGraph module from Query.qll files#8810
Merged
erik-krogh merged 1 commit intogithub:mainfrom Apr 22, 2022
Merged
Ruby: dont import the PathGraph module from Query.qll files#8810erik-krogh merged 1 commit intogithub:mainfrom
erik-krogh merged 1 commit intogithub:mainfrom
Conversation
Contributor
|
Looks fine to me. There seems to be a (unrelated) problem with the identical files check. |
76c8f00 to
a737350
Compare
Contributor
Author
|
I rebased on |
nickrolfe
approved these changes
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the time you import the
PathGraphmodule from the.qlfile of a path-query.But sometimes you also imported it from the
Query.qllfile (I removed those).(I found this from looking at redundant imports, and some of your
PathGraphimports showed up as redundant).