Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh status #5369

Merged
merged 11 commits into from Mar 29, 2022
Merged

gh status #5369

merged 11 commits into from Mar 29, 2022

Conversation

vilmibm
Copy link
Contributor

@vilmibm vilmibm commented Mar 28, 2022

This PR adds a new top level command, gh status. This command shows information about your work on GitHub across all the repositories to which you are subscribed.

The information shown:

  • Assigned issues
  • Assigned PRs
  • Review Requests
  • Mentions
  • Repository Activity (new issues, comments, new PRs)

Screen Shot 2022-03-28 at 11 14 52

What I didn't get to (and would be good followup work):

  • splitting out subcommands for each of these sections
  • doing some sampling so that noisy repos (like cli/cli in my screenshot) aren't overrepresented
    • though this might be too magical
  • including discussion data

@vilmibm vilmibm marked this pull request as ready for review Mar 28, 2022
@vilmibm vilmibm requested a review from as a code owner Mar 28, 2022
@vilmibm vilmibm requested review from mislav (assigned from cli/code-reviewers) and removed request for Mar 28, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Mar 28, 2022
mislav
mislav approved these changes Mar 28, 2022
Copy link
Member

@mislav mislav left a comment

This looks great! The slowness of the cold-start due to the number of API requests is still an issue, although it's mitigated by caching and parallelization. I wouldn't consider this to be a blocker.

Since we now output the OWNER/REPO#NUMBER syntax to identify individual PR & issue threads, I wonder whether it would be useful to provide facilities to use the same syntax as argument to other commands.

# note: this wouldn't work in bash or shells where `#` is strictly
# a comment character no matter where it appears
gh issue view cli/cli#123
gh browse cli/cli#123

Should we consider this as followup? I'm thinking this because I wonder what's the story for using gh to act on items that the user learned about through gh status.

pkg/cmd/status/status.go Outdated Show resolved Hide resolved
pkg/cmd/status/status.go Show resolved Hide resolved
pkg/cmd/status/status.go Outdated Show resolved Hide resolved
pkg/cmd/status/status.go Outdated Show resolved Hide resolved
pkg/cmd/status/status.go Outdated Show resolved Hide resolved
pkg/cmd/status/status.go Show resolved Hide resolved
pkg/cmd/status/status.go Show resolved Hide resolved
pkg/httpmock/stub.go Show resolved Hide resolved
pkg/cmd/status/status.go Outdated Show resolved Hide resolved
pkg/cmd/status/status.go Outdated Show resolved Hide resolved
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Mar 28, 2022
Copy link
Member

@samcoe samcoe left a comment

This is really cool. I am seeing a weird UX issue with the vertical separator next to "Assigned PRs" in my terminal, both kitty and terminal.app. Seem likely it is a lipgloss bug but just wanted to point it out as we might see issues opened up around it.
Screen Shot 2022-03-29 at 12 04 19 PM

Edit: After looking at this a bit more it is clear that the boarder is at the end of each line of the left column and my left column only has three lines so the boarder only displays on three lines. So it is not so much a bug as an artifact of me not having many assigned issues.

@vilmibm
Copy link
Contributor Author

@vilmibm vilmibm commented Mar 29, 2022

@samcoe I tweaked the borders to hopefully fix what you saw.

@mislav Accepting owner/name#123 arguments would be a great improvement, but yeah, only if we'd be comfortable with the comment character problem tripping people up.

@vilmibm vilmibm merged commit e2fd7ce into trunk Mar 29, 2022
10 checks passed
@vilmibm vilmibm deleted the gh-status branch Mar 29, 2022
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Mar 29, 2022
@vilmibm vilmibm mentioned this pull request Mar 30, 2022
4 tasks
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Mar 30, 2022
Copy link

@tuanggolt tuanggolt left a comment

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

None yet

4 participants