C++: More enhancements to PrivateData.qll#8664
Merged
rdmarsh2 merged 3 commits intogithub:mainfrom Apr 4, 2022
Merged
Conversation
rdmarsh2
approved these changes
Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more patterns for detecting private data to
PrivateData.qll, as there were some obvious gaps. All improvements have been briefly tried out with ad-hoc LGTM queries, to avoid expressions that would produce many false positives (which is easy to do).There is still much more we could do here, especially in the fields of medical, family and financial information - but with the present design abbreviations (
mob,DOB,IBANand so forth) tend to produce too many false positives, so things might have to become a little more sophisticated in order to support that.Doesn't really need a change note as the library was only added last week in #8580 (and that did have a change note).