Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-44828: Avoid tkinter file dialog failure on macOS 12 Monterey (GH-29276) #29279

Merged
merged 1 commit into from Oct 28, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 28, 2021

when using the Tk 8.6.11 provided by python.org macOS installers.
Patch by Marc Culler of the Tk project.
(cherry picked from commit be8318b)

Co-authored-by: Ned Deily nad@python.org

https://bugs.python.org/issue44828

…thonGH-29276)

when using the Tk 8.6.11 provided by python.org macOS installers.
Patch by Marc Culler of the Tk project.
(cherry picked from commit be8318b)

Co-authored-by: Ned Deily <nad@python.org>
@ned-deily
Copy link
Member

@ned-deily ned-deily commented Oct 28, 2021

@ambv, As we discussed, here is a courtesy backport of the Monterey Tk fix to the 3.8 branch. We don't expect to ever use it since 3.8 is the security-fix-only phase of its life cycle and thus we no longer provide binary installers for it. BTW, the Docs build failure is addressed in open PR #29245.

@ned-deily ned-deily assigned ambv and ned-deily and unassigned ned-deily Oct 28, 2021
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Oct 28, 2021

@ned-deily: Status check is done, and it's a failure .

@ambv
Copy link
Contributor

@ambv ambv commented Oct 28, 2021

The failure is due to a recent release of docutils 0.18, so far incompatible with Sphinx (sphinx-doc/sphinx#9777). This was already fixed in 3.8 by #29245 (thanks, Ned!). So I'll be landing this.

@ambv ambv merged commit f19c1a1 into python:3.8 Oct 28, 2021
11 of 13 checks passed
@miss-islington miss-islington deleted the backport-be8318b-3.8 branch Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants