Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check paths safely for codespaces SSH and SCP commands #5384

Merged
merged 1 commit into from Mar 31, 2022

Conversation

Copy link
Contributor

@jshorty jshorty commented Mar 31, 2022

For codespaces commands, uses https://github.com/cli/safeexec to avoid searching the current directory before PATH on Windows.

@jshorty jshorty marked this pull request as ready for review Mar 31, 2022
@jshorty jshorty requested a review from as a code owner Mar 31, 2022
@cliAutomation cliAutomation added the external label Mar 31, 2022
@cliAutomation
Copy link
Collaborator

@cliAutomation cliAutomation commented Mar 31, 2022

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Mar 31, 2022
@jshorty
Copy link
Contributor Author

@jshorty jshorty commented Mar 31, 2022

References internal issue codespaces#6895

Copy link
Member

@mislav mislav left a comment

Good catch!

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Mar 31, 2022
@jshorty jshorty merged commit 2df3dd4 into cli:trunk Mar 31, 2022
8 checks passed
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Mar 31, 2022
@kz3003

This comment was marked as spam.

Copy link

@kz3003 kz3003 left a comment

internal/codespaces/ssh.go

@Lonewolf0402

This comment was marked as spam.

@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external
Projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

None yet

6 participants