Skip to content

JS: recognize string replacement chains as scheme checks in js/incomplete-url-scheme-check#8481

Merged
erik-krogh merged 2 commits intogithub:mainfrom
erik-krogh:schemeChain
Mar 25, 2022
Merged

JS: recognize string replacement chains as scheme checks in js/incomplete-url-scheme-check#8481
erik-krogh merged 2 commits intogithub:mainfrom
erik-krogh:schemeChain

Conversation

@erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Mar 18, 2022

@github-actions github-actions bot added the JS label Mar 18, 2022
@esbena
Copy link
Contributor

esbena commented Mar 18, 2022

LGTM, but lets add a test.

@erik-krogh erik-krogh marked this pull request as ready for review March 18, 2022 14:32
@erik-krogh erik-krogh requested a review from a team as a code owner March 18, 2022 14:32
@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Mar 18, 2022
@erik-krogh erik-krogh merged commit cf94c93 into github:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JS no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants