pyright: Don't report incompatible overrides #7498
Merged
+20
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These overrides are inherited from the implementation and are out of typeshed's control.
|
See discussion in #7495. |
|
We should be able to do this for mypy too by turning off the Not totally sure we should do this, though; often incompatible override errors can be ignored, but sometimes they also provide a useful nudge to adjust the annotations on a method that's part of a protocol. |
Personally I'm happy with keeping the mypy errors, but switching off the slightly stricter pyright errors? (I think that's a coherent position?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
These overrides are inherited from the implementation and are out of
typeshed's control.