Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce max_old_space_size for jest tests #15975

Merged
merged 10 commits into from
Mar 10, 2022

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Mar 1, 2022

Why:

Experimenting to see if the jest tests/rendering gets better.

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 1, 2022
@github github deleted a comment from github-actions bot Mar 1, 2022
@github github deleted a comment from github-actions bot Mar 1, 2022
@github github deleted a comment from github-actions bot Mar 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@peterbe peterbe marked this pull request as ready for review March 3, 2022 21:11
@peterbe peterbe requested a review from a team as a code owner March 3, 2022 21:11
@peterbe peterbe requested a review from mikesurowiec March 3, 2022 21:11
@peterbe
Copy link
Contributor Author

peterbe commented Mar 3, 2022

@mikesurowiec It didn't seem to be the silver bullet we had hoped for. But it still seems like the totally right thing to do.

heiskr
heiskr previously approved these changes Mar 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2022

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@peterbe
Copy link
Contributor Author

peterbe commented Mar 4, 2022

@mikesurowiec Now it's just changing the memory amount.
Still, it doesn't appear to solve much. Just a good practice.

@heiskr heiskr merged commit c99afd0 into main Mar 10, 2022
@heiskr heiskr deleted the peterbe-reduce-max_old_space_size-for-jest-tests branch March 10, 2022 21:25
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Copy link
Contributor

@xty xty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have helped with tests on #16181 👍

@peterbe
Copy link
Contributor Author

peterbe commented Mar 10, 2022

This seems to have helped with tests on #16181 👍

Unfortunately, it probably wasn't a silver bullet fix. We were able to see the same jest crashes even with this change made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants