-
Notifications
You must be signed in to change notification settings - Fork 60.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce max_old_space_size for jest tests #15975
reduce max_old_space_size for jest tests #15975
Conversation
|
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
|
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
|
@mikesurowiec It didn't seem to be the silver bullet we had hoped for. But it still seems like the totally right thing to do. |
|
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
|
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are: You'll need to revert all of the files you changed in that list using GitHub Desktop or |
|
@mikesurowiec Now it's just changing the memory amount. |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to have helped with tests on #16181 👍
Unfortunately, it probably wasn't a silver bullet fix. We were able to see the same |
Why:
Experimenting to see if the
jest tests/renderinggets better.What's being changed:
Check off the following:
Writer impact (This section is for GitHub staff members only):