Python: Fix a bunch of QL warnings #8336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the most part, these boil down to "some global property holds, and so this relation contains all instances of class `X`". The fix is to explicitly build the cartesian product (which we were already building implicitly anyway) by adding `and exists(var)` to the disjunct that did not mention `var`. Note that these cartesian products are always with singletons on one side, and so should be unproblematic.
These are all implied by the return type of the other side of the equality.
e7e57fe
to
a41f3cc
c61d340
to
524d17e
524d17e
to
5a8ba6a
yoff
requested changes
Mar 8, 2022
python/tools/recorded-call-graph-metrics/ql/lib/RecordedCalls.qll
Outdated
Show resolved
Hide resolved
Co-authored-by: yoff <lerchedahl@gmail.com>
yoff
approved these changes
Mar 8, 2022
Happy to merge this now.
The Field only used in CharPred-warnings are interesting, but can be tackled later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Does what it says on the tin. Most of the remaining warnings fall into a few classes:
lib. Some of these should probably just be deleted (SVN support, anyone?), but may need a formal deprecation first.All of the changes in this PR should be fairly benign, however.
As this doesn't change the API, I don't think a change note is required.