bpo-46891: Fix creating a new instance of a module subclass with slots#31643
Merged
markshannon merged 2 commits intopython:mainfrom Mar 3, 2022
Merged
bpo-46891: Fix creating a new instance of a module subclass with slots#31643markshannon merged 2 commits intopython:mainfrom
markshannon merged 2 commits intopython:mainfrom
Conversation
vstinner
approved these changes
Mar 2, 2022
Member
vstinner
left a comment
There was a problem hiding this comment.
LGTM, I just have a minor question/remark on the test.
I'm happy to see the _PyType_AllocNoTrack() function that I added being used :-) Objects should only be tracked once their visit function can be safely called.
| __slots__ = ("a", "b") | ||
|
|
||
| def __init__(self, name): | ||
| super().__init__(name) |
Member
There was a problem hiding this comment.
What's the purpose of this method? Maybe assign a and/or b attribute if you want to keep it? Or remove it?
Contributor
There was a problem hiding this comment.
The important bit is having __slots__ in the class definition, I just checked and leaving out the __init__ method still reproduces the crash that this PR fixes.
Member
There was a problem hiding this comment.
Well, I approved the PR. @markshannon can decide to keep or remove the method, it doesn't really matter ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46891