Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codespaces Create: Allow Accepting Permissions #5234

Merged
merged 7 commits into from Feb 28, 2022
Merged

Codespaces Create: Allow Accepting Permissions #5234

merged 7 commits into from Feb 28, 2022

Conversation

markphelps
Copy link
Contributor

@markphelps markphelps commented Feb 22, 2022

Fixes: github/codespaces#5779

Allows the codespaces create command to handle errors that require the user to accept additional repository permissions before creating the codespace. See the above linked issue for demo/details.

@markphelps markphelps requested review from as code owners Feb 22, 2022
@markphelps markphelps requested review from samcoe (assigned from cli/code-reviewers) and removed request for Feb 22, 2022
@cliAutomation cliAutomation added the external label Feb 22, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Feb 22, 2022
markphelps
markphelps reviewed Feb 22, 2022
View changes
pkg/cmd/codespace/create.go Outdated Show resolved Hide resolved
josebalius
josebalius approved these changes Feb 22, 2022
View changes
Copy link
Member

@josebalius josebalius left a comment

LGTM, left a couple of comments but nothing blocking!

pkg/cmd/codespace/create.go Outdated Show resolved Hide resolved
pkg/cmd/codespace/create.go Show resolved Hide resolved
pkg/cmd/codespace/create.go Outdated Show resolved Hide resolved
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Feb 22, 2022
mislav
mislav previously requested changes Feb 22, 2022
View changes
internal/codespaces/api/api.go Show resolved Hide resolved
pkg/cmd/codespace/create.go Outdated Show resolved Hide resolved
pkg/cmd/codespace/create.go Outdated Show resolved Hide resolved
pkg/cmd/codespace/create.go Outdated Show resolved Hide resolved
pkg/cmd/codespace/create.go Outdated Show resolved Hide resolved
The GitHub CLI automation moved this from Needs to be merged 🎉 to Needs review 🤔 Feb 22, 2022
@markphelps markphelps requested a review from mislav Feb 22, 2022
@markphelps markphelps marked this pull request as draft Feb 23, 2022
@markphelps markphelps marked this pull request as ready for review Feb 23, 2022
@markphelps markphelps requested a review from josebalius Feb 23, 2022
@vilmibm vilmibm dismissed mislav’s stale review Feb 28, 2022

Changes were handled and Mislav is on PTO

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Feb 28, 2022
@vilmibm vilmibm merged commit 91c4a5d into cli:trunk Feb 28, 2022
6 checks passed
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Feb 28, 2022
@markphelps markphelps deleted the codespaces-accept-perms branch Mar 1, 2022
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Mar 1, 2022
Kalakaarboyz1

This comment has been minimized.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greggroth greggroth

@gdomingu gdomingu

@vilmibm vilmibm

@samcoe samcoe

@mislav mislav

@josebalius josebalius

Assignees

@vilmibm vilmibm

Labels
external
Projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@markphelps @mislav @vilmibm @josebalius @greggroth @gdomingu @Kalakaarboyz1 @cliAutomation