Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
WIP: ENH: infinite sheds #717
Conversation
* add _to_radians and is_rad to convert only if necessary * prefix all functions with get_ * add get_f_sky_pv, get_poa_sky_pv, get_ground_angle_tangent, get_f_gnd_pv, get_f_gnd_pv, get_poa_gnd_pv, etc. * update API ui Signed-off-by: Mark Mikofski <bwana.marko@yahoo.com>
* get_irradiance, output ordered dict or dataframe * finish updating get_poa_global_bifacial to transpose beam and diffuse for each side separately
…ion" - use tan(zenith) in solar projection math latex - implement gcr_prime and ground-sky-angles calculations - add stub for ground-diffuse view factor Signed-off-by: Mark Mikofski <bwana.marko@yahoo.com>
- calculate ground-sky angles to previous and next rows, assuming height is nonzero - calculate limits on ground where it can see the sky - calculate the view factor as a function of z on the ground to the sky - fix places where it still says degrees, bad, no! - add fixme for pv-sky view factor, still has wrong formula - add tests for angles from point z on the ground to tops of current row, and limits of previous and next rows - add a script to make the plot of ground-sky view factor versus z
|
Sorry for the delay. Getting closer! Here's the view factor of the sky diffuse from the ground between rows as a function of point z on the ground between rows, starting where the line from the panel intersects the ground: |
|
@wholmgren FYI: looks like pandas and other versions not supported by python-3.5, not sure? |
- add comments, change names x->z - add TODO's to limit number of rows, and set row-type: 'first', 'last', or 'middle'
- was difference of angles, should be difference of cosines - also add TODO's to return VF versus point x on panel, and don't use averages
|
Cliff mentioned that in the ivtools pr (I think). I haven’t had a chance to
look into it. Probably should be addressed in a separate pr.
…On Wed, Jul 3, 2019 at 5:38 PM Mark Mikofski ***@***.***> wrote:
@wholmgren <https://github.com/wholmgren> FYI: looks like pandas and
other versions not supported by python-3.5
<https://travis-ci.org/pvlib/pvlib-python/jobs/554012857#L379>, not sure?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#717?email_source=notifications&email_token=ABBOER75RFF75U7MYDRY3DLP5VBAFA5CNFSM4HMBP67KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZGAEYQ#issuecomment-508297826>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABBOER4OIOK4O57A5QKOCZLP5VBAFANCNFSM4HMBP67A>
.
|
- change calc_fx_sky to calc_fz_sky since z is for ground and x is for pv surface - add docstring to calc_fz_sky and for ground_sky_diffuse_view_factor
* change _bigz() to just return bigz * create a test figure of integrated vslue
|
@cwhanse & @kanderso-nrel I think the best way to wrap this up is to separate it from Bill Marion's implementation and submit that separately, in fact I think I can improve https://GitHub.Com/nrel/bifacialvf enough that we can use it directly. That way I can just reference the 2019 SolarFarmer bifacial PVSC paper, and be done. Kevin, the approach here is kind of halfway between the diffuse sky PR you just merged & Bill Marion's approach, except that this method developed by Jeff Newmiller was to plot the view factor from Bill's method across the receiver width and observe that it is roughly linear so that a linear average of VF is used, although Jeff's approach splits the receiver into shaded and unshaded regions (if needed) and supplies average view factors for each (shaded & unshaded). So, different from Marion who provides view factors as a function of location on the receiver, and different from Passias (#1017) who averages the making angle, and instead this PR averages the view factor given by Marion. Sound good? This is like 90% done just needs a tiny push to finish. Two validation papers will be presented in September at EUPVSEC |
Signed-off-by: Mark Mikofski <bwana.marko@yahoo.com>
As I commented, this approach seems backwards to me and would create extra work. Why not move the ground-sky and specific bifacial stuff out of this PR to a new PR for |
Begin work on infinite sheds for pv arrays
guidelines
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):