Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove needless gender specific terms. #855 #2258

Merged
merged 1 commit into from Jan 21, 2022
Merged

Remove needless gender specific terms. #855 #2258

merged 1 commit into from Jan 21, 2022

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented Jan 21, 2022

Cleanup grating unmodern gender wording text in old PEPs that were pointed out
in #855.
@gpshead
Remove needless gender specific terms. python#855
be66810 
Cleanup grating unmodern gender wording text in old PEPs that were pointed out
in python#855.
@gpshead gpshead requested a review from brettcannon Jan 21, 2022
@gpshead gpshead requested review from gvanrossum, mhammond and as code owners Jan 21, 2022
@Rosuav
Copy link
Contributor

@Rosuav Rosuav commented Jan 21, 2022

IMO this is unnecessary churn.

gvanrossum
gvanrossum approved these changes Jan 21, 2022
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

LGTM.

@gpshead gpshead merged commit da9bf5f into python:main Jan 21, 2022
3 checks passed
@gpshead gpshead deleted the gh855-degendering branch Jan 21, 2022
gvanrossum
gvanrossum reviewed Jan 22, 2022
View changes
pep-3119.txt
@@ -115,7 +115,7 @@ documentation for the ABC. These standard semantic definitions are
not enforced, but are strongly recommended.

Like all other things in Python, these promises are in the nature of a
gentlemen's agreement, which in this case means that while the
friendly agreement, which in this case means that while the
Copy link
Member

@gvanrossum gvanrossum Jan 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“mutual understanding” ?

Copy link
Member

@CAM-Gerlach CAM-Gerlach Jan 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that could work, albeit with a bit of rewriting. Retaining "agreement" as the second word would be more of a drop-in replacement, though perhaps "understanding" is more what you intend here? As for the first word, perhaps "non-binding" or "informal" better capture the desired meaning? Up to you.

Copy link
Member

@merwok merwok Jan 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had informal agreement in my head too.

Copy link
Member

@CAM-Gerlach CAM-Gerlach Jan 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had informal agreement in my head too.

That's probably the closest match for the original word, for what its worth

@CAM-Gerlach CAM-Gerlach mentioned this pull request Jan 31, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok

@gvanrossum gvanrossum

@CAM-Gerlach CAM-Gerlach

@brettcannon brettcannon

@mhammond mhammond

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
6 participants
@gpshead @Rosuav @merwok @gvanrossum @CAM-Gerlach @the-knights-who-say-ni