C++: Promote cpp/non-https-url#8227
Merged
MathiasVP merged 6 commits intogithub:mainfrom Feb 25, 2022
Merged
Conversation
MathiasVP
previously approved these changes
Feb 24, 2022
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
Excellent! LGTM except for a minor question.
MathiasVP
approved these changes
Feb 24, 2022
Contributor
|
DCA looks good! There are a couple of failures, but that's because you made the same mistake I did in #8173 of using a recent semmle-code SHA, but without a sufficiently recent CodeQL SHA (which gave a dbscheme mismatch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a minor source of (arguable) false positives in
cpp/non-https-url, then promote it to@precision high. LGTM results for this query have previously shown a low number of false positives.Here's the query running on some relevant projects: before and after the change.