Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Separate the ML model for ML-powered queries into its own pack #8151

Merged
merged 4 commits into from Feb 22, 2022

Conversation

@henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Feb 21, 2022

This has a number of benefits, including enabling users to more easily get started with development: running codeql pack install from the -queries pack will now install the ML model.

Commit-by-commit review recommended: one of the commits documents why the ML model pack isn't part of the default workspace.

henrymercer added 2 commits Feb 21, 2022
This allows users to more easily get started with development. Running
`codeql pack install` from the `-queries` pack will now install the ML
model.
We only want to put the checked out version of the model pack to test a
custom model.
Given that the repo doesn't contain any models by default, most users
won't want the local checkout of the model pack to override the one
downloaded from the package registry.
@github-actions github-actions bot added the JS label Feb 21, 2022
@henrymercer henrymercer force-pushed the henrymercer/separate-atm-model-pack branch 5 times, most recently from c996c6a to 0a2adae Feb 21, 2022
@henrymercer henrymercer force-pushed the henrymercer/separate-atm-model-pack branch 2 times, most recently from 9b69578 to 393a82c Feb 21, 2022
@henrymercer henrymercer force-pushed the henrymercer/separate-atm-model-pack branch from 393a82c to 02cce62 Feb 21, 2022
@henrymercer henrymercer marked this pull request as ready for review Feb 21, 2022
@henrymercer henrymercer requested a review from as a code owner Feb 21, 2022
Copy link

@annarailton annarailton left a comment

Really positive change, thank you!

@henrymercer henrymercer merged commit 4f7604f into main Feb 22, 2022
19 checks passed
@henrymercer henrymercer deleted the henrymercer/separate-atm-model-pack branch Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants