bpo-46730: Fix refleak and tighten NULL checks #31389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``PyType_GetQualName`` returns a new reference. Signed-off-by: Christian Heimes <christian@python.org>
|
I'll try to be more cautious about ref-leaks in the future. Thanks for catching this! |
|
If you want to schedule another build, you need to add the " |
JelleZijlstra
approved these changes
Feb 17, 2022
|
@sweeneyde The buildbots have not finished verifying this PR yet. Next time please wait until all buildbots are successful. |
|
Ah, my apologies, I was just looking at the refleak bots. I will wait next time. Thank you for the help! |
|
Oh, apologies, should have checked that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PyType_GetQualNamereturns a new reference.Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue46730