Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused __all__ variables from Trio's modules #1500

Closed
njsmith opened this issue May 7, 2020 · 0 comments
Closed

Remove unused __all__ variables from Trio's modules #1500

njsmith opened this issue May 7, 2020 · 0 comments

Comments

@njsmith
Copy link
Member

@njsmith njsmith commented May 7, 2020

This is a minor issue, so let's leave it for someone who hasn't made any PRs yet and wants a simple one to practice one.

The issue: lots of Trio's modules have __all__ variables defined. That's because once upon a time, trio/__init__.py used these __all__ variables to figure out what to re-export as part of the main namespace. But we stopped doing that a long time ago, because it confused static analysis tools. So now the __all__ variables are vestigial, aren't being updated, and don't actually do anything except clutter up the code, and potentially confuse readers. So we should do a sweep through and delete them all.

njsmith added a commit that referenced this issue May 13, 2020
[#1500]: Remove unused __all__ variables from Trio modules
@njsmith njsmith closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant