Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46333: include module in ForwardRef.__repr__ #31283

Merged

Conversation

aha79
Copy link
Contributor

@aha79 aha79 commented Feb 11, 2022

The module parameter carries semantic information about the forward ref.
Show to the user that forward refs with same argument but different
module are different.

This is the split-off part from GH-30536 which should not be backported.

https://bugs.python.org/issue46333

The module parameter carries semantic information about the forward ref.
Show to the user that forward refs with same argument but different
module are different.
@JelleZijlstra JelleZijlstra self-requested a review Feb 11, 2022
@AlexWaygood AlexWaygood added the type-feature label Feb 12, 2022
@gvanrossum gvanrossum merged commit b70690b into python:main Feb 12, 2022
12 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 12, 2022

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@aha79 aha79 deleted the bpo-46333_include_module_in_forward_ref_repr branch Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed type-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants