Workflows: Augment workflow to ensure failure with invalid change notes #7946
Conversation
62d4585 to
ca1317a
Compare
|
Example of a failing workflow: https://github.com/github/codeql/runs/5148220083?check_suite_focus=true |
bd01c86 to
142a929
Compare
142a929 to
9441ea9
Compare
dbartol
left a comment
There was a problem hiding this comment.
A couple minor things worth looking at.
| - "*/ql/src/**/*.qll" | ||
| - "!**/experimental/**" | ||
| - "!ql/**" | ||
| - ".github/workflows/check-change-not.yml" |
There was a problem hiding this comment.
| - ".github/workflows/check-change-not.yml" | |
| - ".github/workflows/check-change-note.yml" |
| - "!**/experimental/**" | ||
| - "!ql/**" | ||
| - ".github/workflows/check-change-not.yml" | ||
|
|
There was a problem hiding this comment.
Should change */ql/src/**/*.qll to */ql/**/*.qll (and same for .ql). Otherwise we're not running on changes that only affect the library packs.
There was a problem hiding this comment.
This was committed accidentally. I think we should exclude tests and example packs from here. So, I will add a line like this: */ql/lib/**/*.qll. Same for *.ql. It's not really related to this change, but I'll add it anyway.
| github.event.pull_request.draft == false | ||
| run: | | ||
| codeql pack release --groups cpp,csharp,java,javascript,python,ruby,-examples,-test,-experimental |
There was a problem hiding this comment.
Does this actually fail the step if codeql returns non-zero? I thought you needed set -e to make that happen.
There was a problem hiding this comment.
Here is a workflow run that I intentionally failed. https://github.com/github/codeql/runs/5148220083?check_suite_focus=true It fails the job as well.
Library pack changes were being ignored.
aibaars
left a comment
There was a problem hiding this comment.
Looks great to me. Thanks for adding this check.
No description provided.