Skip to content

QL: Use of db-type outside language core.#7674

Merged
tausbn merged 2 commits intogithub:mainfrom
erik-krogh:dbTypeInNonLib
Feb 11, 2022
Merged

QL: Use of db-type outside language core.#7674
tausbn merged 2 commits intogithub:mainfrom
erik-krogh:dbTypeInNonLib

Conversation

@erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jan 20, 2022

Raw database types should only be used inside the lib/ folder.

I fixed the 1 alert for JS by moving the file into the lib/ folder.

@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Jan 20, 2022
@erik-krogh erik-krogh marked this pull request as ready for review January 20, 2022 14:54
@erik-krogh erik-krogh requested review from a team as code owners January 20, 2022 14:54
@aschackmull
Copy link
Contributor

Sounds reasonable.

Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@tausbn tausbn merged commit 327e0da into github:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JS no-change-note-required This PR does not need a change note QL-for-QL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants