Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: add insecureRandomness #7252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Python: add insecureRandomness #7252

wants to merge 1 commit into from
+198 −0

Conversation

@museljh
Copy link

@museljh museljh commented Nov 28, 2021 •
edited
Loading

Any suggestion is welcome, please leave me messages of your opinions
@museljh museljh requested a review from as a code owner Nov 28, 2021
@owen-mc owen-mc changed the title add insecureRandomness Python: add insecureRandomness Nov 28, 2021
@RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Nov 30, 2021 •
edited
Loading

Thanks for this PR @museljh 👍 I have not looked in great detail on the code, but just wanted to check whether this was intended to be part of the Security Lab bounty program, or just a normal contribution?

I can also see that that you did not add any tests, as a minimum, could you please add the ones from your examples to a new test-folder (python/ql/test/experimental/query-tests/Security/CWE-388-InsecureRandomness/) ? 😊

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github/codeql-python codeql-python

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Python
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@museljh @RasmusWL