C++: fix IR generation for constructor base inits when no constructor is present.#7839
Merged
MathiasVP merged 2 commits intoFeb 4, 2022
Merged
Conversation
MathiasVP
approved these changes
Feb 4, 2022
MathiasVP
left a comment
Contributor
There was a problem hiding this comment.
LGTM! We should probably create an extractor issue for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class has no virtual members and no constructor, but an explicitly written destructor, constructors for classes that inherit from it will have a generated call to the nonexistent constructor, leading to any later entries in the initializer list being dropped in the IR. This PR works around the issue by adding a minimal translation for the broken call, allowing later entries in the list to be included in the IR.