Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicates check results returned by gh pr checks #5069

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix duplicates check results returned by gh pr checks #5069

wants to merge 1 commit into from
+253 −14

Conversation

@hirasawayuki
Copy link
Contributor

@hirasawayuki hirasawayuki commented Jan 20, 2022

Fixes #4946
If a same checks are performed later, API will return duplicates of the same checks.
Therefore, when the same check is returned, the latest check is given priority to eliminate duplicates.
@hirasawayuki hirasawayuki requested a review from as a code owner Jan 20, 2022
@hirasawayuki hirasawayuki requested review from vilmibm (assigned from cli/code-reviewers) and removed request for Jan 20, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Jan 20, 2022
@hirasawayuki hirasawayuki changed the title Fix API results returned by gh pr checks cmd Fix duplicates check results returned by gh pr checks Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilmibm vilmibm

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
external
Projects
The GitHub CLI
  
Needs review 🤔
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

gh pr checks retains stale checks until a new commit is pushed
2 participants
@hirasawayuki @cliAutomation