Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45792: Fix contextvar.Token's intersphinx FQN #29533

Merged
merged 1 commit into from Nov 12, 2021
Merged

Conversation

Copy link
Member

@hynek hynek commented Nov 12, 2021

Since .. module:: contextvars sets the module using .. class:: contextvars.Token, intersphinx records it as contextvars.contextvars.Token.

https://bugs.python.org/issue45792

Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
Copy link
Contributor

@asvetlov asvetlov left a comment

LGTM, thanks!

@asvetlov asvetlov merged commit e501d70 into python:main Nov 12, 2021
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 12, 2021

Thanks @hynek for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9, 3.10.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Nov 12, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <hs@ox.cx>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 12, 2021

GH-29535 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Nov 12, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <hs@ox.cx>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 12, 2021

GH-29536 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 12, 2021

GH-29537 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 12, 2021

GH-29538 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Nov 12, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <hs@ox.cx>
asvetlov pushed a commit that referenced this issue Nov 12, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <hs@ox.cx>

Co-authored-by: Hynek Schlawack <hs@ox.cx>
asvetlov pushed a commit that referenced this issue Nov 12, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <hs@ox.cx>

Co-authored-by: Hynek Schlawack <hs@ox.cx>
@hynek hynek deleted the bpo-45792 branch Nov 12, 2021
ambv pushed a commit that referenced this issue Nov 16, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <hs@ox.cx>
remykarem added a commit to remykarem/cpython that referenced this issue Dec 7, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
remykarem added a commit to remykarem/cpython that referenced this issue Jan 30, 2022
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants