Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] bpo-42103: Improve validation of Plist files. (GH-22882) #23118

Merged
merged 1 commit into from Nov 10, 2020

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 2, 2020

  • Prevent some possible DoS attacks via providing invalid Plist files
    with extremely large number of objects or collection sizes.
  • Raise InvalidFileException for too large bytes and string size instead of returning garbage.
  • Raise InvalidFileException instead of ValueError for specific invalid datetime (NaN).
  • Raise InvalidFileException instead of TypeError for non-hashable dict keys.
  • Add more tests for invalid Plist files..
    (cherry picked from commit 34637a0)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

https://bugs.python.org/issue42103

* Prevent some possible DoS attacks via providing invalid Plist files
  with extremely large number of objects or collection sizes.
* Raise InvalidFileException for too large bytes and string size instead of returning garbage.
* Raise InvalidFileException instead of ValueError for specific invalid datetime (NaN).
* Raise InvalidFileException instead of TypeError for non-hashable dict keys.
* Add more tests for invalid Plist files..
(cherry picked from commit 34637a0)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot bedevere-bot added type-bug type-security labels Nov 2, 2020
@ned-deily ned-deily merged commit a63234c into python:3.6 Nov 10, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed type-bug type-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants