Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44061: Fix pkgutil.iter_modules regression #25964

Merged
merged 6 commits into from May 11, 2021
Merged

bpo-44061: Fix pkgutil.iter_modules regression #25964

merged 6 commits into from May 11, 2021

Conversation

@miguendes
Copy link
Contributor

@miguendes miguendes commented May 7, 2021 •
edited

https://bugs.python.org/issue44061
zooba
zooba reviewed May 7, 2021
View changes
Lib/test/test_pkgutil.py Outdated Show resolved Hide resolved
@AnnaStepakova AnnaStepakova mentioned this pull request May 8, 2021
Merged
zooba
zooba reviewed May 10, 2021
View changes
Lib/test/test_pkgutil.py Outdated Show resolved Hide resolved
zooba
zooba reviewed May 11, 2021
View changes
Copy link
Member

@zooba zooba left a comment

Couple of minor test tweaks, and once applied I'll make sure CI runs and then it should be good.

Lib/test/test_pkgutil.py Outdated Show resolved Hide resolved
Lib/test/test_pkgutil.py Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2021-05-07-08-39-23.bpo-44061.MvElG6.rst Outdated Show resolved Hide resolved
miguendes and others added 3 commits May 11, 2021
@miguendes @zooba
Update Lib/test/test_pkgutil.py
7743718 
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@miguendes @zooba
Update Lib/test/test_pkgutil.py
3582959 
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@miguendes @zooba
Update Misc/NEWS.d/next/Library/2021-05-07-08-39-23.bpo-44061.MvElG6.rst
91cae78 
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@zooba zooba merged commit e9d7f88 into python:main May 11, 2021
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 11, 2021

Thanks @miguendes for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 11, 2021

Sorry, @miguendes and @zooba, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e9d7f88d5643f7e6387bf994c130503766d7eb92 3.9

zooba added a commit to zooba/cpython that referenced this issue May 11, 2021
@miguendes @zooba
bpo-44061: Fix pkgutil.iter_modules regression when passed a pathlib.…
7655c85 
…Path object (pythonGH-25964)
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 11, 2021

GH-26052 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 12, 2021

Thanks @miguendes for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 12, 2021

Sorry @miguendes and @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e9d7f88d5643f7e6387bf994c130503766d7eb92 3.8

ambv pushed a commit that referenced this issue May 12, 2021
@miguendes @zooba
bpo-44061: Fix pkgutil.iter_modules regression when passed a pathlib.…
0cb9775 
…Path object (GH-25964) (GH-26052)

Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
ambv added a commit to ambv/cpython that referenced this issue May 12, 2021
@miguendes @ambv
[3.8] bpo-44061: Fix pkgutil.iter_modules regression when passed a pa…
f8f2b10 
…thlib.Path object (pythonGH-25964).

(cherry picked from commit e9d7f88)

Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 12, 2021

GH-26056 is a backport of this pull request to the 3.8 branch.

ambv added a commit that referenced this issue May 12, 2021
@miguendes @ambv
[3.8] bpo-44061: Fix pkgutil.iter_modules regression when passed a pa…
4844abd 
…thlib.Path object (GH-25964). (GH-26056)

(cherry picked from commit e9d7f88)

Co-authored-by: Miguel Brito <5544985+miguendes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

Assignees

@zooba zooba

Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@miguendes @miss-islington @bedevere-bot @zooba @ambv @the-knights-who-say-ni