bpo-46602: Do not append conftest.c#31062
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: @adanhawth For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
The heredoc creation statements use >> to append conftest.c. This can cause tricky build issues if the file is not correctly removed prior to its name being reused (such name is reused several times for different contextual tests during the build). One such result from appending may cause #include <ac_nonexistent.h> to persist when testing to acquire PLATFORM_TRIPLET. This can then lead to downstream issues concerning SOABI.
|
Thanks for the PR; the changes to |
|
@adanhawth Looking through a list of checks I noticed failed bedevere/news — No news entry in Misc/NEWS.d/next/ or "skip news" label found. I forgot to say that you also need to add a short changelog entry using https://blurb-it.herokuapp.com/add_blurb. It can be, for example, I cannot do it by myself because I have no push access to your PR, but it will look like this:
|
ned-deily
left a comment
There was a problem hiding this comment.
The changes look good to me. I gather from the comments that you have experienced "tricky build problems" as configure now stands. For that reason, I think it might be a good idea to add a NEWS item for this change since others might have also run into the problem, assuming the problem description can be meaningfully described in a few lines; see the description of blurb and blurb-it in the devguide.
|
@arhadthedev, sorry, I didn't see your comment before I made mine :) |
|
Thanks again for the PR and congrats on your first cpython PR. |
|
You're welcome. Thank you, both, for the timely feedback. |
The heredoc creation statements use >> to append conftest.c. This can cause
tricky build issues if the file is not correctly removed prior to its
name being reused (such name is reused several times for different
contextual tests during the build). One such result from appending may
cause #include <ac_nonexistent.h> to persist when testing to acquire
PLATFORM_TRIPLET. This can then lead to downstream issues concerning SOABI.
https://bugs.python.org/issue46602