Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46600: ./configure --with-pydebug uses -Og with clang #31052

Merged
merged 2 commits into from Feb 1, 2022

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 1, 2022

Fix the test checking if the C compiler supports -Og option in the
./configure script to also use -Og on clang which supports it.

https://bugs.python.org/issue46600

Fix the test checking if the C compiler supports -Og option in the
./configure script to also use -Og on clang which supports it.
@vstinner
Copy link
Member Author

@vstinner vstinner commented Feb 1, 2022

configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
@vstinner
Copy link
Member Author

@vstinner vstinner commented Feb 1, 2022

@erlend-aasland: Done, I added a second commit to use _SAVE_VAR/_RESTORE_VAR.

@vstinner vstinner merged commit 0515eaf into python:main Feb 1, 2022
12 checks passed
@vstinner vstinner deleted the clang_og branch Feb 1, 2022
@pablogsal
Copy link
Member

@pablogsal pablogsal commented Feb 1, 2022

This PR seems to have broken a bunch of buildbots. If no fix is provided in 24 hours, we will need to revert :(

@vstinner
Copy link
Member Author

@vstinner vstinner commented Feb 1, 2022

This PR seems to have broken a bunch of buildbots. If no fix is provided in 24 hours, we will need to revert :(

Sure, the law is the law. I proposed a fix: GH-31058.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants