Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46591: Make About IDLE doc link label clickable #30251

Merged
merged 8 commits into from Feb 2, 2022
Merged

bpo-46591: Make About IDLE doc link label clickable #30251

merged 8 commits into from Feb 2, 2022

Conversation

@wesinator
Copy link
Contributor

@wesinator wesinator commented Dec 25, 2021 •
edited by bedevere-bot

This PR makes the IDLE doc link on the Help -> About dialog open the web browser
If you're going to have a link in about page, might as well have it open to the browser.

image

https://stackoverflow.com/questions/23482748/how-to-create-a-hyperlink-with-a-label-in-tkinter

Merry Christmas and Happy Holidays,

https://bugs.python.org/issue46591
@wesinator wesinator requested a review from terryjreedy as a code owner Dec 25, 2021
TeamSpen210
TeamSpen210 reviewed Dec 25, 2021
View changes
Lib/idlelib/help_about.py Outdated Show resolved Hide resolved
@github-actions
Copy link

@github-actions github-actions bot commented Jan 31, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jan 31, 2022
@terryjreedy terryjreedy changed the title IDLE about dialog - add open action to docs link bpo-46591: Make About IDLE label with doc link clickable Jan 31, 2022
@terryjreedy terryjreedy changed the title bpo-46591: Make About IDLE label with doc link clickable bpo-46591: Make About IDLE doc link label clickable Jan 31, 2022
terryjreedy
terryjreedy requested changes Jan 31, 2022
View changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Please add a blurb (using 'blurb' installed on your machine or the blurb-it link you should see at the bottom of the main PR page). The following will be enough.
"Make the IDLE doc URL on the About IDLE dialog clickable."

Approved with the 2 requested changes.

Lib/idlelib/help_about.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jan 31, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

wesinator and others added 2 commits Jan 31, 2022
@wesinator @terryjreedy
lambda webbrowser.open
9730116 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@blurb-it
📜🤖 Added by blurb_it.
0206923
@wesinator
Copy link
Contributor Author

@wesinator wesinator commented Jan 31, 2022

I have made the requested changes; please review again

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jan 31, 2022

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from terryjreedy Jan 31, 2022
@terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Feb 1, 2022

Your original lambda was correct in having an e[vent] parameter. It could not have worked since widget options are not attributes. This should have been live tested.

I tried adding a unittest, but testing an event binding is very hard. I tried adding a separate button, both to make it obvious that one could open the url and because testing button functions is relatively easy. But the button was too ugly. I settled for adding url testing to the human acceptance testing instruction. (This appears when running the idlelib file rather than the unittest file.) I think this sufficient since there is nothing tricky about the new line and anyone touching it should do a live test.

@terryjreedy terryjreedy merged commit 53c7808 into python:main Feb 2, 2022
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 2, 2022

Thanks @wesinator for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 2, 2022

Sorry @wesinator and @terryjreedy, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 53c78080573b3bae4c4e782b9f47dce48aac9688 3.10

miss-islington added a commit to miss-islington/cpython that referenced this issue Feb 2, 2022
@wesinator @miss-islington
bpo-46591: Make About IDLE doc link label clickable (pythonGH-30251)
ae09b0e 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 53c7808)

Co-authored-by: Wes <5124946+wesinator@users.noreply.github.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 2, 2022

GH-31067 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 2, 2022

Thanks @wesinator for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 2, 2022

GH-31068 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Feb 2, 2022
@wesinator @miss-islington
bpo-46591: Make About IDLE doc link label clickable (pythonGH-30251)
4b1f435 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 53c7808)

Co-authored-by: Wes <5124946+wesinator@users.noreply.github.com>
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 2, 2022

Thanks @wesinator for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Feb 2, 2022
@wesinator @miss-islington
bpo-46591: Make About IDLE doc link label clickable (pythonGH-30251)
3d0d8ba 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 53c7808)

Co-authored-by: Wes <5124946+wesinator@users.noreply.github.com>
miss-islington added a commit that referenced this issue Feb 2, 2022
@wesinator @miss-islington
bpo-46591: Make About IDLE doc link label clickable (GH-30251)
a1869e3 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 53c7808)

Co-authored-by: Wes <5124946+wesinator@users.noreply.github.com>
miss-islington added a commit that referenced this issue Feb 2, 2022
@wesinator @miss-islington
bpo-46591: Make About IDLE doc link label clickable (GH-30251)
7dee93c 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 53c7808)

Co-authored-by: Wes <5124946+wesinator@users.noreply.github.com>
@wesinator wesinator deleted the patch-1 branch Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeamSpen210 TeamSpen210

@terryjreedy terryjreedy

Assignees

@terryjreedy terryjreedy

Labels
CLA signed type-enhancement
Projects
None yet
Milestone
No milestone
6 participants
@wesinator @bedevere-bot @terryjreedy @miss-islington @TeamSpen210 @the-knights-who-say-ni