C#: Make TypeParameterConstraints a CachedEntity#7766
Merged
hvitved merged 1 commit intogithub:mainfrom Jan 28, 2022
Merged
Conversation
michaelnebel
approved these changes
Jan 28, 2022
| public override void WriteId(EscapingTextWriter trapFile) | ||
| { | ||
| trapFile.WriteSubId(parent); | ||
| trapFile.Write(";typeparameterconstraints"); |
Contributor
There was a problem hiding this comment.
Could you remind me, why this is needed (we are only doing this for entities and not fresh entities).
Contributor
Author
There was a problem hiding this comment.
It is to give a unique ID to the entity. If we simply did trapFile.WriteSubId(parent); it would overlap with the ID of the parent.
Contributor
There was a problem hiding this comment.
Ok, so the ID we write into the trap, is basically the same as the parent id except that we postfix it with ";typeparameterconstraints"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #7456, in preparation for shared extraction.