Update reference to the parser from LL(1) to PEG #767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Nov 14, 2021
langchanges.rst
Outdated
| @@ -47,8 +47,8 @@ You will first need a PEP that you will present to python-ideas. You may be a | |||
| little hazy on the technical details as various core developers can help with | |||
| that, but do realize that if you do not present your idea to python-ideas or | |||
| python-list ahead of time you may find out it is technically not possible | |||
| (e.g., Python's parser will not support the grammar change as it is an LL(1) | |||
| parser). Expect extensive comments on the PEP, some of which will be negative. | |||
| (e.g., Python's parser will not support the grammar change as a PEG parser). | |||
There was a problem hiding this comment.
I think the whole sentence in parentheses should be removed
There was a problem hiding this comment.
removed and updated PR
per feedback from @pablogsal
|
Thanks for the PR @itamaro ! |
AA-Turner
pushed a commit
to AA-Turner/devguide
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if this is considered a minor fix, let me know if I should file an issue for this first