Replacing "each country" by " eachtranslation"#757
Merged
encukou merged 1 commit intopython:masterfrom Nov 16, 2021
Merged
Conversation
While it is easy to understand what was meant by "country", this is inaccurate. While I believe most people know why, I'll still be explicit here. Some countries have multiple languages, each having their translation (e.g. Canada with English and French) and some languages are spoken in many countries, and the regional variation are small enough that there will probably never be multiple translation. (While Canadian French and France French are so different that it's sometime hard for French native to understand French Canadian speaking, I doubt anybody will want to create a ca-fr translation, given that the technical language will probably be almost the same)
Member
|
Thank you! |
Member
|
I agree with the replacement. A grammar fix is also needed: "each translation have to sort this out" should be "translations have to sort this out" or "each translation has to sort this out". I prefer the latter because I understand the sorting out is to be done by each translation group independently. This would also be a no-issue 'typo' fix. |
Member
|
It might help if a native English speaker went through the whole Translating section to fix up idioms and bits of grammar. |
Contributor
Author
|
I'm sorry, but I'm French and I don't believe I could do any good job at hunting the grammar part of the content |
AA-Turner
pushed a commit
to AA-Turner/devguide
that referenced
this pull request
Jun 17, 2022
While it is easy to understand what was meant by "country", this is inaccurate. Some countries have multiple languages, each having their translation (e.g. Canada with English and French) and some languages are spoken in many countries, and the regional variation are small enough that there will probably never be multiple translations. (While Canadian French and France French are so different that it's sometimes hard for French native to understand French Canadian speaking, I doubt anybody will want to create a ca-fr translation, given that the technical language will probably be almost the same.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing "each country" by " each translation"
While it is easy to understand what was meant by "country", this is inaccurate. While I believe most people know why, I'll still be explicit here. Some countries have multiple languages, each having their translation (e.g. Canada with English and French) and some languages are spoken in many countries, and the regional variation are small enough that there will probably never be multiple translation. (While Canadian French and France French are so different that it's sometime hard for French native to understand French Canadian speaking, I doubt anybody will want to create a ca-fr translation, given that the technical language will probably be almost the same)
While not a typo, I assume the issue is so small that it can be considered as a typo. But if required, I'll go open a bpo