Automatically create an issue if the nightly stubtest run fails#6978
Merged
Akuli merged 14 commits intopython:masterfrom Jan 20, 2022
Merged
Automatically create an issue if the nightly stubtest run fails#6978Akuli merged 14 commits intopython:masterfrom
Akuli merged 14 commits intopython:masterfrom
Conversation
srittau
reviewed
Jan 20, 2022
.github/workflows/stubtest.yml
Outdated
| name: Create an issue if stubtest failed | ||
| runs-on: ubuntu-latest | ||
| needs: [stubtest-stdlib, stubtest-third-party] | ||
| if: ${{ github.repository == 'python/typeshed' && always() && (needs.stubtest-stdlib.result=='failure' || needs.stubtest-third-party.result=='failure') }} |
Collaborator
Author
There was a problem hiding this comment.
It prevents the job from getting cancelled if the needs jobs fail: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-not-requiring-successful-dependent-jobs
Collaborator
There was a problem hiding this comment.
Yikes, what horrible feature design.
srittau
approved these changes
Jan 20, 2022
Collaborator
srittau
left a comment
There was a problem hiding this comment.
LGTM, but I'd like the feedback of more maintainers in the original issue (or here).
JelleZijlstra
approved these changes
Jan 20, 2022
sobolevn
reviewed
Jan 20, 2022
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6972
Example issue: Akuli#21
It would be nice to include the name of the failing library in the issue title. This isn't as easy as I expected, because we can't give the
issues: writepermission to the same job that runs stubtest (and executes code from pypi). We could do this with upload-artifact and download-artifact, or by downloading raw logs of the failed jobs. But this is already much better than a script that runs only on my computer, and can be improved later.