bpo-46299: improve test_descr.py with stricter error handling
#30471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
reviewed
Jan 7, 2022
Misc/NEWS.d/next/Tests/2022-01-08-01-39-57.bpo-46299.8SsRqA.rst
Outdated
Show resolved
Hide resolved
corona10
reviewed
Jan 7, 2022
| @@ -4452,6 +4450,8 @@ def __getattr__(self, attr): | |||
| print("Oops!") | |||
| except RuntimeError: | |||
| pass | |||
| else: | |||
There was a problem hiding this comment.
Would you like to update the test by using
from contextlib import redirect_stdout?
There was a problem hiding this comment.
Thanks for the idea! But, I went for the smallest diff.
corona10
approved these changes
Jan 8, 2022
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 8, 2022
…onGH-30471) (cherry picked from commit e63066c) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-30476 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 8, 2022
…onGH-30471) (cherry picked from commit e63066c) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-30477 is a backport of this pull request to the 3.10 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue46299