➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2022-01-07 10:36 by zsol, last changed 2022-01-08 18:23 by taleinat. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 30450 | merged | zsol, 2022-01-07 10:37 | |
| PR 30482 | merged | miss-islington, 2022-01-08 10:56 | |
| PR 30483 | merged | miss-islington, 2022-01-08 10:56 | |
| Messages (8) | |||
|---|---|---|---|
| msg409957 - (view) | Author: Zsolt Dollenstein (zsol) * | Date: 2022-01-07 10:36 | |
Parameter names for `asdict`, `astuple`, `is_dataclass`, and `replace` are incorrect in the docs. The first parameter for all these is `obj`. |
|||
| msg410089 - (view) | Author: Tal Einat (taleinat) *  |
Date: 2022-01-08 10:13 | |
Indeed, the argument name in the code is "obj", and in 3 of those 4 functions it is a normal (positional or keyword) argument, so the name is important. |
|||
| msg410094 - (view) | Author: Tal Einat (taleinat) * |
Date: 2022-01-08 10:56 | |
New changeset ef5376e69e72fa922d7f1b3df47b99d3576f9df1 by Zsolt Dollenstein in branch 'main': bpo-46290: Fix parameter names in dataclasses docs (GH-30450) https://github.com/python/cpython/commit/ef5376e69e72fa922d7f1b3df47b99d3576f9df1 |
|||
| msg410099 - (view) | Author: miss-islington (miss-islington) | Date: 2022-01-08 15:09 | |
New changeset 8bef658668bac923166ae160c79720aed5f3b712 by Miss Islington (bot) in branch '3.10': bpo-46290: Fix parameter names in dataclasses docs (GH-30450) https://github.com/python/cpython/commit/8bef658668bac923166ae160c79720aed5f3b712 |
|||
| msg410100 - (view) | Author: miss-islington (miss-islington) | Date: 2022-01-08 15:10 | |
New changeset cd95033d9c27d6c541dfd774b4c5eab4a70a23ab by Miss Islington (bot) in branch '3.9': bpo-46290: Fix parameter names in dataclasses docs (GH-30450) https://github.com/python/cpython/commit/cd95033d9c27d6c541dfd774b4c5eab4a70a23ab |
|||
| msg410101 - (view) | Author: Tal Einat (taleinat) * |
Date: 2022-01-08 15:14 | |
Thanks for the report and the PR, Zsolt! |
|||
| msg410102 - (view) | Author: Eric V. Smith (eric.smith) * |
Date: 2022-01-08 18:13 | |
Thanks for committing this, @taleinat. But next time, if it's assigned to me, I'd like to review it first. Thanks! |
|||
| msg410103 - (view) | Author: Tal Einat (taleinat) * |
Date: 2022-01-08 18:23 | |
Good to know Eric, will do! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-01-08 18:23:29 | taleinat | set | messages: + msg410103 |
| 2022-01-08 18:13:52 | eric.smith | set | messages: + msg410102 |
| 2022-01-08 15:14:33 | taleinat | set | status: open -> closed nosy: - miss-islington messages: + msg410101 resolution: fixed stage: patch review -> resolved |
| 2022-01-08 15:10:01 | miss-islington | set | messages: + msg410100 |
| 2022-01-08 15:09:45 | miss-islington | set | messages: + msg410099 |
| 2022-01-08 10:56:49 | miss-islington | set | pull_requests: + pull_request28687 |
| 2022-01-08 10:56:44 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request28686 |
| 2022-01-08 10:56:41 | taleinat | set | messages: + msg410094 |
| 2022-01-08 10:13:31 | taleinat | set | assignee: eric.smith -> taleinat messages: + msg410089 nosy: + taleinat |
| 2022-01-07 15:00:03 | eric.smith | set | assignee: docs@python -> eric.smith |
| 2022-01-07 11:00:37 | AlexWaygood | set | nosy:
+ eric.smith type: behavior |
| 2022-01-07 10:37:34 | zsol | set | keywords:
+ patch stage: patch review pull_requests: + pull_request28655 |
| 2022-01-07 10:36:09 | zsol | create | |