Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(objects): use self.encoded_id where could be a string #1835

Merged
merged 1 commit into from Jan 14, 2022
Merged

chore(objects): use self.encoded_id where could be a string #1835

merged 1 commit into from Jan 14, 2022

Conversation

@JohnVillalovos
Copy link
Collaborator

@JohnVillalovos JohnVillalovos commented Jan 14, 2022

Updated a few remaining usages of self.id to use self.encoded_id
where it could be a string value.
@JohnVillalovos
chore(objects): use self.encoded_id where could be a string
c3c3a91 
Updated a few remaining usages of `self.id` to use `self.encoded_id`
where it could be a string value.
@JohnVillalovos JohnVillalovos requested a review from nejch Jan 14, 2022
nejch
nejch approved these changes Jan 14, 2022
View changes
@nejch nejch enabled auto-merge Jan 14, 2022
@nejch nejch merged commit 34110dd into main Jan 14, 2022
14 checks passed
@nejch nejch deleted the jlvillal/id_to_encodedid branch Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@JohnVillalovos @nejch