Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QL4QL: catch behaviour/behavior in ql/non-us-spelling #7443

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

QL4QL: catch behaviour/behavior in ql/non-us-spelling #7443

wants to merge 2 commits into from

Conversation

@nickrolfe
Copy link
Contributor

@nickrolfe nickrolfe commented Dec 17, 2021

No description provided.

@nickrolfe nickrolfe marked this pull request as ready for review Dec 17, 2021
@nickrolfe nickrolfe requested review from erik-krogh, tausbn and as code owners Dec 17, 2021
owen-mc
owen-mc approved these changes Dec 17, 2021
View changes
Copy link
Contributor

@owen-mc owen-mc left a comment

I don't understand the Code scanning warning, but this PR is obviously good.

@erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Dec 17, 2021

I don't understand the Code scanning warning, but this PR is obviously good.

If you're talking about the Consistency predicate that should be empty-warning, then it's caused by the QL-for-QL parser being confused about trailing commas in set literals.
We know about it, and it will get fixed (after Taus has reworked the Tree-sitter grammars).

erik-krogh
erik-krogh approved these changes Dec 17, 2021
View changes
Copy link
Contributor

@erik-krogh erik-krogh left a comment •
edited

JS and QL-for-QL 👍

hvitved
hvitved approved these changes Dec 17, 2021
View changes
Copy link
Contributor

@hvitved hvitved left a comment

C# 👍

MathiasVP
MathiasVP approved these changes Dec 17, 2021
View changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

C++ 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved

@MathiasVP MathiasVP

@erik-krogh erik-krogh

@owen-mc owen-mc

@tausbn tausbn

@github/codeql-java codeql-java

@github/codeql-python codeql-python

Assignees
No one assigned
Labels
C# C++ documentation Java JS no-change-note-required Python
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nickrolfe @erik-krogh @hvitved @MathiasVP @owen-mc