Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Model what is written to the log from stdlib Logger methods #7399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@alexrford
Copy link
Contributor

@alexrford alexrford commented Dec 14, 2021

The Logging concept is borrowed from Python's Concepts.qll.

This encodes what may be present in log output from stdlib Logger instances, covering the following methods:

  • add/log
  • debug, error, fatal, info, unknown, and warn
  • <<
  • progname=

add/log only execute their block and include its return value in log output when the message argument is nil (this is also its default value). See the test cases or Logger#add for details.

@alexrford alexrford added the Ruby label Dec 14, 2021
@alexrford alexrford requested a review from as a code owner Dec 14, 2021
Copy link
Contributor

@nickrolfe nickrolfe left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants