New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-10712; Update release scripts to Python3 #11538

Merged

dajac merged 1 commit into apache:trunk from dajac:KAFKA-10712

Nov 29, 2021

Contributor

dajac commented Nov 25, 2021 •

edited

Made the following changes so that it works in Python3:

Use print() instead of print
Decode all of the cmd outputs from binary to string using UTF-8
Encode string to binary using UTF-8 when necessary
Use input instead of raw_input
Replace usages of basestring by str

Committer Checklist (excluded from commit message)

Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)

The text was updated successfully, but these errors were encountered:


          KAFKA-10712; Update release scripts to Python3

a35d2d3

dajac reviewed

View changes

release.py

  
                if version == 8:

                  if "1.8.0" not in java_version:

                    fail("JDK 8 is required")

                elif "%d.0" % version not in java_version and '"%d"' % version not in java_version:

Contributor Author

dajac Nov 25, 2021

We had a bug here. The script should fail if both conditions are not met.

dajac requested a review from mimaison

Contributor Author

dajac commented Nov 25, 2021 •

edited

I've ran the script and everything seems to work correctly.

mimaison approved these changes

View changes

Member

mimaison left a comment

Thanks for picking this up. LGTM

dajac merged commit cec4d23 into apache:trunk

5 of 10 checks passed

dajac deleted the KAFKA-10712 branch

dajac added a commit that referenced this issue


          KAFKA-10712; Update release scripts to Python3 (#11538)

31d32f1

Reviewers: Mickael Maison <mickael.maison@gmail.com>

hgeraldino added a commit to hgeraldino/kafka that referenced this issue


          KAFKA-10712; Update release scripts to Python3 (apache#11538)

c5bdb23

Reviewers: Mickael Maison <mickael.maison@gmail.com>

xdgrulez pushed a commit to xdgrulez/kafka that referenced this issue


          KAFKA-10712; Update release scripts to Python3 (apache#11538)

e51e5c9

Reviewers: Mickael Maison <mickael.maison@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment