Skip to content

Conversation

@MathiasVP
Copy link
Contributor

On main (on php):

Tuple counts for SSAUtils::SSAHelper::phi_node#fff/3@i2#c6b1fxk6 after 7.7s:
  256024    ~0%      {3} r1 = SCAN SSAUtils::SSAHelper::ssa_defn_rec_dispred#fff#prev_delta OUTPUT In.1 'v', In.0 'this', In.2
  104208654 ~0%      {4} r2 = JOIN r1 WITH SSAUtils::live_at_start_of_bb#ff ON FIRST 1 OUTPUT Lhs.1 'this', Lhs.0 'v', Lhs.2, Rhs.1 'b'
  90588757  ~0%      {4} r3 = r2 AND NOT SSAUtils::SSAHelper::phi_node#fff#prev(Lhs.0 'this', Lhs.1 'v', Lhs.3 'b')
  90588757  ~2%      {4} r4 = SCAN r3 OUTPUT In.2, In.3 'b', In.0 'this', In.1 'v'
  82651     ~79%     {3} r5 = JOIN r4 WITH SSAUtils::dominanceFrontier#ff ON FIRST 2 OUTPUT Lhs.2 'this', Lhs.3 'v', Lhs.1 'b'
                      return r5
...
>>> Created relation SSAUtils::SSAHelper::phi_node_dispred#fff/3@80af8ckn with 155170 rows.

On this PR:

Tuple counts for SSAUtils::SSAHelper::phi_node_dispred#fff/3@i2#c9f58w5t after 103ms:
  256024 ~2%      {3} r1 = SCAN SSAUtils::SSAHelper::ssa_defn_rec_dispred#fff#prev_delta OUTPUT In.2, In.0 'this', In.1 'v'
  196746 ~64%     {3} r2 = JOIN r1 WITH SSAUtils::dominanceFrontier#ff ON FIRST 1 OUTPUT Rhs.1 'b', Lhs.1 'this', Lhs.2 'v'
  124032 ~6%      {3} r3 = r2 AND NOT SSAUtils::SSAHelper::phi_node_dispred#fff#prev(Lhs.1 'this', Lhs.2 'v', Lhs.0 'b')
  124032 ~2%      {3} r4 = SCAN r3 OUTPUT In.2 'v', In.0 'b', In.1 'this'
  44842  ~0%      {3} r5 = JOIN r4 WITH SSAUtils::live_at_start_of_bb#ff ON FIRST 2 OUTPUT Lhs.2 'this', Lhs.0 'v', Lhs.1 'b'
                  return r5
...
>>> Created relation SSAUtils::SSAHelper::phi_node_dispred#fff/3@c9f58w5t with 155170 rows.

It's slightly difficult to compare the tuple counts on a per-iteration basis, so I've included the final tuple counts in the resulting predicate to show that the number of tuples doesn't change.

@MathiasVP MathiasVP added the C++ label Dec 17, 2021
@MathiasVP MathiasVP requested a review from a team as a code owner December 17, 2021 07:57
@aschackmull aschackmull merged commit c03f189 into github:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants