➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2021-12-09 09:23 by christian.heimes, last changed 2021-12-14 14:42 by christian.heimes.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 30001 | merged | christian.heimes, 2021-12-09 09:27 | |
| PR 30100 | merged | christian.heimes, 2021-12-14 14:12 | |
| Messages (4) | |||
|---|---|---|---|
| msg408091 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2021-12-09 09:23 | |
Modules/Setup can disable a module. However makesetup does not take *disabled* into account when it generated Makefile. Example: ---Modules/Setup.local *disabled* pwd --- makesetup generates a Makefile with "pwd" in MODDISABLED_NAMES and MODBUILT_NAMES. Because "pwd" is in MODBUILT_NAMES the module is built and included in python binary. Expected result: "pwd" module should not be built. |
|||
| msg408208 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2021-12-10 13:12 | |
New changeset 036bbb1d1b6156a1a72c40e9f907f302505085bc by Christian Heimes in branch 'main': bpo-46023: Fix makesetup handling of disabled rule (GH-30001) https://github.com/python/cpython/commit/036bbb1d1b6156a1a72c40e9f907f302505085bc |
|||
| msg408523 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2021-12-14 11:53 | |
GH-30001 may have introduced a regression. makesetup is dropping too many modules. Back to the drawing board! |
|||
| msg408531 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2021-12-14 14:42 | |
New changeset 74821b30539bba3cf0ac4148923ec0e9b826508e by Christian Heimes in branch 'main': bpo-46023: Skip build if module is marked as DISABLED (GH-30100) https://github.com/python/cpython/commit/74821b30539bba3cf0ac4148923ec0e9b826508e |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2021-12-14 14:42:56 | christian.heimes | set | messages: + msg408531 |
| 2021-12-14 14:12:58 | christian.heimes | set | pull_requests: + pull_request28322 |
| 2021-12-14 11:53:02 | christian.heimes | set | messages: + msg408523 |
| 2021-12-10 13:12:06 | christian.heimes | set | messages: + msg408208 |
| 2021-12-09 09:27:32 | christian.heimes | set | keywords:
+ patch stage: patch review pull_requests: + pull_request28225 |
| 2021-12-09 09:23:50 | christian.heimes | create | |