C#: Initial implementation of csv printing in FlowSummaries test #7178
+3,305
−2,982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79d0261
to
1824df5
michaelnebel
reviewed
Nov 22, 2021
michaelnebel
reviewed
Nov 22, 2021
michaelnebel
reviewed
Nov 22, 2021
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
michaelnebel
reviewed
Nov 22, 2021
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
michaelnebel
reviewed
Nov 22, 2021
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
michaelnebel
reviewed
Nov 22, 2021
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
michaelnebel
reviewed
Nov 22, 2021
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
michaelnebel
reviewed
Nov 22, 2021
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
Outdated
Show resolved
Hide resolved
michaelnebel
reviewed
Nov 22, 2021
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImplSpecific.qll
Outdated
Show resolved
Hide resolved
michaelnebel
reviewed
Nov 22, 2021
michaelnebel
reviewed
Nov 22, 2021
csharp/ql/test/library-tests/frameworks/EntityFramework/FlowSummaries.ql
Outdated
Show resolved
Hide resolved
27b914c
to
43180b4
michaelnebel
reviewed
Nov 23, 2021
michaelnebel
reviewed
Nov 23, 2021
michaelnebel
reviewed
Nov 23, 2021
ee3d34b
to
8f172bf
fe81d26
to
ae09212
michaelnebel
reviewed
Nov 24, 2021
csharp/ql/test/library-tests/frameworks/EntityFramework/FlowSummaries.expected
Show resolved
Hide resolved
…ries. Note that any non NormalReturnKind printed summary will not be in the flow summary CSV language
…ts for ruby and java
hvitved
requested changes
Nov 24, 2021
Some trivial comments; otherwise looks great!
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImplSpecific.qll
Outdated
Show resolved
Hide resolved
| import semmle.code.csharp.dataflow.internal.FlowSummaryImpl::Private::TestOutput | ||
|
|
||
| abstract class IncludeSummarizedCallable extends RelevantSummarizedCallable { | ||
| /** Gets the qualified parameter types of this callable as a comma-separated string */ |
There was a problem hiding this comment.
All ql doc comments should end with a full stop .
There was a problem hiding this comment.
Will fix (and also look at the other comments). Is there a documented coding standard?
There was a problem hiding this comment.
tamasvajk
reviewed
Nov 24, 2021
hvitved
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In this PR we change the way flow summaries are printed in the FlowSummaries.expected file.
The idea is that the printing result should be parseable as flow summaries written in CSV format.
This holds for the dataflow/libraries flow summaries test, but not for frameworks/EntityFramework.
For the latter case, we extend the the printing of ReturnKind slightly for the special cases, where the return kind is not a normal return kind. This means that these strings are not parsable as flow summaries.
Furthermore, the tests has been updated to reflect the new way of printing.
The text was updated successfully, but these errors were encountered: