Highlights
Pinned
433 contributions in the last year
Less
More
Activity overview
Contributed to
nodejs/node,
nodejs/node-addon-api,
open-telemetry/opentelemetry-js
and 5 other
repositories
Contribution activity
October 2021
Created 20 commits in 4 repositories
Created 1 repository
- legendecas/opentelemetry-js-api TypeScript
Created a pull request in open-telemetry/opentelemetry-js that received 11 comments
feat(api-metrics): remove bind/unbind and bound instruments
Which problem is this PR solving?
Removes metric.bind/unbind and bound instrument types from api-metrics. This PR didn't change the data flow or fu…
+114
−290
•
11
comments
Opened 21 other pull requests in 5 repositories
tc39/test262
7
merged
- Add WrappedFunction coverage on non-callable proxy
- Add tests on ShadowRealm WrappedFunction value wrapping
- WrappedFunction should accept callable proxy
- Remove unnecessary eval to access realm globals
- Fix ShadowRealm/prototype/importValue/not-constructor.js
- Add test for ShadowRealm.prototype.evaluate throwing realm check
- Add tests for cross realms in ShadowRealm.prototype.evaluate
open-telemetry/opentelemetry-js
3
open
2
merged
1
closed
- feat(api-metrics): async instruments spec compliance
- feat(sdk-metrics-base): remove per-meter config on MeterProvider.getMeter
- chore: slim font size for section title in PR template
- fix(sdk-metrics-base): remove metric kind BATCH_OBSERVER
- fix(api-metrics): distinguish bound counter and bound up down counter type
- feat(api-metrics): add schemaUrl to meter creations
tc39/proposal-shadowrealm
4
merged
tc39/agendas
2
merged
open-telemetry/opentelemetry-js-api
2
open
Reviewed 11 pull requests in 5 repositories
open-telemetry/opentelemetry-js
5 pull requests
nodejs/node-addon-api
2 pull requests
open-telemetry/opentelemetry-js-contrib
2 pull requests
tc39/ecma262
1 pull request
nodejs/node
1 pull request
Created an issue in tc39/proposal-shadowrealm that received 23 comments
Ergonomics on WrappedFunction thisArgument throwing when it is an object
As for now, WrappedFunction.[[Call]] converts the thisArgument to wrapped value and then passes the wrapped this argument to the target function in…
23
comments