bpo-45573: Move mandatory core modules to Modules/Setup.bootstrap (GH-29616) #29616
+136
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
be740b2
to
0db8a04
erlend-aasland
suggested changes
Nov 18, 2021
This is a nice improvement. Not all modules that #define Py_BUILD_CORE_MODULE are included in Modules/Setup.core. Is Modules/Setup.builtin a more "correct" name?
Modules that define Py_BUILD_CORE_MODULE
$ grep -r "#.*define.*Py_BUILD_CORE_MODULE" Modules | sort
Modules/_abc.c:# define Py_BUILD_CORE_MODULE 1
Modules/_asynciomodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_blake2/blake2b_impl.c:# define Py_BUILD_CORE_MODULE 1
Modules/_blake2/blake2module.c:# define Py_BUILD_CORE_MODULE 1
Modules/_blake2/blake2s_impl.c:# define Py_BUILD_CORE_MODULE 1
Modules/_ctypes/_ctypes.c:# define Py_BUILD_CORE_MODULE 1
Modules/_ctypes/callbacks.c:# define Py_BUILD_CORE_MODULE 1
Modules/_ctypes/cfield.c:# define Py_BUILD_CORE_MODULE 1
Modules/_ctypes/stgdict.c:# define Py_BUILD_CORE_MODULE 1
Modules/_cursesmodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_datetimemodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_decimal/_decimal.c:# define Py_BUILD_CORE_MODULE 1
Modules/_hashopenssl.c:# define Py_BUILD_CORE_MODULE 1
Modules/_heapqmodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_json.c:# define Py_BUILD_CORE_MODULE 1
Modules/_lsprof.c:# define Py_BUILD_CORE_MODULE 1
Modules/_pickle.c:# define Py_BUILD_CORE_MODULE 1
Modules/_posixsubprocess.c:# define Py_BUILD_CORE_MODULE 1
Modules/_queuemodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_randommodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_sha3/sha3module.c:# define Py_BUILD_CORE_MODULE 1
Modules/_struct.c:# define Py_BUILD_CORE_MODULE 1
Modules/_testinternalcapi.c:# define Py_BUILD_CORE_MODULE 1
Modules/_testmultiphase.c:# define Py_BUILD_CORE_MODULE 1
Modules/_xxsubinterpretersmodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/_zoneinfo.c:# define Py_BUILD_CORE_MODULE 1
Modules/arraymodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/binascii.c:# define Py_BUILD_CORE_MODULE 1
Modules/cmathmodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/mathmodule.c:# define Py_BUILD_CORE_MODULE 1
Modules/md5module.c:# define Py_BUILD_CORE_MODULE 1
Modules/sha1module.c:# define Py_BUILD_CORE_MODULE 1
Modules/sha256module.c:# define Py_BUILD_CORE_MODULE 1
Modules/sha512module.c:# define Py_BUILD_CORE_MODULE 1
Modules/unicodedata.c:# define Py_BUILD_CORE_MODULE 1
configure.ac
Outdated
| dnl alias for static core modules (Modules/Setup.core) | ||
| AU_ALIAS([PY_STDLIB_MOD_CORE], [PY_STDLIB_MOD_SIMPLE]) |
There was a problem hiding this comment.
Why the alias?
The term core is overloaded. I have not found a better term, though.
|
|
Yeah, |
erlend-aasland
reviewed
Nov 19, 2021
Signed-off-by: Christian Heimes <christian@python.org>
erlend-aasland
approved these changes
Nov 19, 2021
Great! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue45573
The text was updated successfully, but these errors were encountered: