Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45548: Remove checks for finite and gamma (GH-29206) #29206

Merged
merged 1 commit into from Oct 25, 2021
Merged

bpo-45548: Remove checks for finite and gamma (GH-29206) #29206

merged 1 commit into from Oct 25, 2021

Conversation

Reviewers

@mdickinson mdickinson

Assignees
No one assigned
Labels
CLA signed 🤖 automerge skip news
Projects
None yet
Milestone
No milestone
4 participants
@tiran @bedevere-bot @mdickinson @the-knights-who-say-ni
@tiran
Copy link
Member

@tiran tiran commented Oct 25, 2021 •
edited by miss-islington
Loading

HAVE_FINITE and HAVE_*GAMMA are not used any more. This fixes a build
issue. Configure doesn't detect finite and gamma on macOS.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45548

Automerge-Triggered-By: GH:tiran
@tiran
bpo-45548: Remove checks for finite and gamma
745e1b0 
HAVE_FINITE and HAVE_*GAMMA are not used any more. This fixes a build
issue. Configure doesn't detect finite and gamma on macOS.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran requested a review from mdickinson Oct 25, 2021
@tiran
Copy link
Member Author

@tiran tiran commented Oct 25, 2021

@mdickinson ARM64 macOS does not have finite and gamma functions:

https://buildbot.python.org/all/#/builders/721/builds/63/steps/2/logs/stdio

checking for x87-style double rounding... no
checking for acosh... yes
checking for asinh... yes
checking for atanh... yes
checking for erf... yes
checking for erfc... yes
checking for expm1... yes
checking for finite... no
checking for gamma... no
checking for lgamma... yes
checking for log1p... yes
checking for log2... yes
checking for tgamma... yes

Loading

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 25, 2021

🤖 New build scheduled with the buildbot fleet by @tiran for commit 745e1b0 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

Loading

@mdickinson
Copy link
Member

@mdickinson mdickinson commented Oct 25, 2021

ARM64 macOS does not have finite and gamma functions:

Makes sense; I don't think either of those is standard. C99 specifies lgamma and tgamma but not gamma, and an isfinite macro but not finite.

Loading

mdickinson
mdickinson approved these changes Oct 25, 2021
View changes
Copy link
Member

@mdickinson mdickinson left a comment

LGTM

Loading

@tiran tiran changed the title bpo-45548: Remove checks for finite and gamma bpo-45548: Remove checks for finite and gamma (GH-29206) Oct 25, 2021
@tiran tiran merged commit 77e3f22 into python:main Oct 25, 2021
74 of 76 checks passed
Loading
@tiran tiran deleted the bpo-45548-gamma branch Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment