Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45716: Improve the error message when using True/False/None as keywords in a call #29413

Merged
merged 1 commit into from Nov 5, 2021
Merged

bpo-45716: Improve the error message when using True/False/None as keywords in a call #29413

merged 1 commit into from Nov 5, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 4, 2021 •
edited by bedevere-bot

@pablogsal pablogsal requested a review from lysnikolaou as a code owner Nov 4, 2021
@pablogsal pablogsal added 🤖 automerge PR will be merged once it's been approved and all CI passed needs backport to 3.10 labels Nov 4, 2021
@cfbolz
Copy link
Contributor

cfbolz commented Nov 4, 2021

The patch looks good to me!

przemub
przemub approved these changes Nov 4, 2021
View changes
Copy link

@przemub przemub left a comment

I like this :)

@pablogsal pablogsal merged commit e2d6563 into python:main Nov 5, 2021
12 checks passed
@pablogsal pablogsal deleted the bpo-45716 branch Nov 5, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Nov 5, 2021

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Nov 5, 2021

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e2d65630f36712dbdbf7711520c985c526a5cc25 3.10

pablogsal added a commit to pablogsal/cpython that referenced this pull request Nov 5, 2021
@pablogsal
[3.10] bpo-45716: Improve the error message when using True/False/Non…
9bd6e67 
…e as keywords in a call (pythonGH-29413).

(cherry picked from commit e2d6563)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Nov 5, 2021

GH-29428 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

bedevere-bot commented Nov 5, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit e2d6563.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/307) and take a look at the build logs.
  4. Check if the failure is related to this commit (e2d6563) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/307

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

410 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 34 sec
  • test_multiprocessing_spawn: 2 min 36 sec
  • test_multiprocessing_forkserver: 1 min 49 sec
  • test_unparse: 1 min 27 sec
  • test_asyncio: 1 min 16 sec
  • test_tokenize: 1 min 15 sec
  • test_logging: 1 min 2 sec
  • test_lib2to3: 58.6 sec
  • test_capi: 51.2 sec
  • test_ssl: 46.9 sec

1 test altered the execution environment:
test_ftplib

16 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_msilib
test_multiprocessing_fork test_ossaudiodev test_spwd
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 11 min

Click to see traceback logs 
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_77f8fb34'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: '/psm_af9b2ceb'


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 90, in read
    obj.handle_read_event()
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 384, in handle_read_event
    self._do_ssl_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 345, in _do_ssl_handshake
    self.socket.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/ssl.py", line 1346, in do_handshake
    self._sslobj.do_handshake()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ssl.SSLZeroReturnError: TLS/SSL connection has been closed (EOF) (_ssl.c:998)


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1031, in _bootstrap_inner
    self.run()
    ^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 298, in run
    asyncore.loop(timeout=0.1, count=1)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 214, in loop
    poll_fun(timeout, map)
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 157, in poll
    read(obj)
    ^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/asyncore.py", line 94, in read
    obj.handle_error()
    ^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ftplib.py", line 421, in handle_error
    raise Exception
    ^^^^^^^^^^^^^^^
Exception
k

pablogsal added a commit that referenced this pull request Nov 16, 2021
@pablogsal
[3.10] bpo-45716: Improve the error message when using True/False/Non…
5618c81 
…e as keywords in a call (GH-29413). (GH-29428)

(cherry picked from commit e2d6563)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemub przemub

@lysnikolaou lysnikolaou

Assignees

@pablogsal pablogsal

Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pablogsal @cfbolz @miss-islington @bedevere-bot @przemub @the-knights-who-say-ni