Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39452: [doc] Change "must" to "can", on relative import style in __main__ modules #29379

Merged
merged 1 commit into from Nov 6, 2021
Merged

bpo-39452: [doc] Change "must" to "can", on relative import style in __main__ modules #29379

merged 1 commit into from Nov 6, 2021

Conversation

@andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Nov 2, 2021 •
edited by bedevere-bot
Loading

The referenced link (https://docs.python.org/3.11/tutorial/modules.html#intra-package-references) says nothing about a requirement on the relative import style.

https://bugs.python.org/issue39452
@ambv ambv removed the skip issue label Nov 6, 2021
@ambv ambv changed the title [doc] Change "must" to "can", on relative import style in __main__ modules bpo-39452: [doc] Change "must" to "can", on relative import style in __main__ modules Nov 6, 2021
@ambv ambv merged commit 57457a1 into python:main Nov 6, 2021
11 checks passed
Loading
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 6, 2021

Thanks @andresdelfino for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

Loading

miss-islington added a commit to miss-islington/cpython that referenced this issue Nov 6, 2021
@andresdelfino @miss-islington
bpo-39452: [doc] Change "must" to "can" on relative import style in `…
0cc5f7b 
…__main__` (pythonGH-29379)

(cherry picked from commit 57457a1)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 6, 2021

Sorry, @andresdelfino and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 57457a1e5caf714034a75fe4f382b8b669ce6ed8 3.9

Loading

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 6, 2021

GH-29449 is a backport of this pull request to the 3.10 branch.

Loading

@ambv
Copy link
Contributor

@ambv ambv commented Nov 6, 2021

Yeah, this won't be backported to 3.9 as the document there is much different.

Loading

@ambv
Copy link
Contributor

@ambv ambv commented Nov 6, 2021

Thanks, Andre!

Loading

ambv pushed a commit that referenced this issue Nov 6, 2021
@andresdelfino @miss-islington
bpo-39452: [doc] Change "must" to "can" on relative import style in `…
e53cb98 
…__main__` (GH-29379) (GH-29449)

(cherry picked from commit 57457a1)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
remykarem added a commit to remykarem/cpython that referenced this issue Dec 7, 2021
@andresdelfino @remykarem
bpo-39452: [doc] Change "must" to "can" on relative import style in `…
85d3aae 
…__main__` (pythonGH-29379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@andresdelfino @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni