Dataflow: Refactor public references to DataFlowCallable#7000
Merged
aschackmull merged 4 commits intogithub:mainfrom Oct 29, 2021
Merged
Dataflow: Refactor public references to DataFlowCallable#7000aschackmull merged 4 commits intogithub:mainfrom
aschackmull merged 4 commits intogithub:mainfrom
Conversation
MathiasVP
approved these changes
Oct 29, 2021
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
C++ 👍 Do we need to run any performance tests on this? Or do we know that this won't affect any join orders?
Contributor
Author
I don't think that's necessary. The refactor is essentially just renaming, and it's even hidden under a layer of caching. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the type
DataFlowCallablebe publicly exposed throughNode::getEnclosingCallableandParameterNode::isParameterOf, which simultaneously serve as interface points between the language-specific parts and the shared library, is unfortunate as it leaks implementation details to users of the data flow library.This refactor splits those predicates, such that a separate pair of private aliases serve as the interface points instead. This allows us to subsequently change the
DataFlowCallabletype with internal implementation details without changing the publicly exposed predicates.